Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiline display equations in HTML #1518

Merged
merged 5 commits into from
Feb 9, 2021
Merged

Fix multiline display equations in HTML #1518

merged 5 commits into from
Feb 9, 2021

Conversation

odow
Copy link
Collaborator

@odow odow commented Feb 3, 2021

This came from the JuMP docs: jump-dev/JuMP.jl#2447 (comment). We have some multiline display equations with \n in them (e.g., to format arrays).

Follows: #1426

Seems like it also fixes #1387

Is there a better way of testing this? I just followed #1426.

@odow odow mentioned this pull request Feb 3, 2021
Merged
@odow
Copy link
Collaborator Author

odow commented Feb 3, 2021

Ideas on the failing docs/pdf/make.jl build?

@mortenpi
Copy link
Member

mortenpi commented Feb 4, 2021

Ideas on the failing docs/pdf/make.jl build?

I think you end up with literal \ and n characters in the TeX code in the updated examples now, since they are raw"" strings?

@odow
Copy link
Collaborator Author

odow commented Feb 4, 2021

Oh, thanks. I though I recalled raw" being cleverer than that with \n.

@odow
Copy link
Collaborator Author

odow commented Feb 5, 2021

Tests passing.

@mortenpi mortenpi added this to the 0.26.2 milestone Feb 9, 2021
mortenpi
mortenpi approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expanded the tests a bit, but otherwise LGTM! Thanks @odow!

@odow
Copy link
Collaborator Author

odow commented Feb 9, 2021

Thanks Morten.

@mortenpi mortenpi merged commit 93e253a into JuliaDocs:master Feb 9, 2021
mortenpi pushed a commit that referenced this pull request Feb 9, 2021
@odow @mortenpi
Fix multiline display equations in HTML (#1518)
313cad4 
(cherry picked from commit 93e253a)
@mortenpi mortenpi mentioned this pull request Feb 9, 2021
Merged
@blegat blegat mentioned this pull request Feb 12, 2021
Closed
@odow odow deleted the od/multiline branch October 13, 2021 04:00
odow added a commit to odow/Documenter.jl that referenced this pull request Oct 13, 2021
@odow
Fix multiline display equations in LaTeX
28c8b34 
This is an identical bugfix fo JuliaDocs#1518, which was only applied to the
HTML writer.
@odow odow mentioned this pull request Oct 13, 2021
Merged
odow added a commit to odow/Documenter.jl that referenced this pull request Oct 14, 2021
@odow
Fix multiline display equations in LaTeX
3db794a 
This is an identical bugfix fo JuliaDocs#1518, which was only applied to the
HTML writer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi mortenpi approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
0.26.2
Development

Successfully merging this pull request may close these issues.

Error: mode == :single requires the Markdown string to parse into a single block │
2 participants
@odow @mortenpi